Hi Ujay, appreciate the pull request! Just to clarify, the canister is designed to exclude the Cypher credential intentionally. That's why I didn't include one. I've left it to the user to generate their encryption key and provide encoding characters. This way, for users who value heightened secrecy, they can generate unique encryption keys and encoding characters for each message. It's important to note that messages can only be deciphered by someone possessing the exact encryption key and encoding characters.

We can maybe provide default encryption credentials while giving the users the chance to set how strong they want their messge to be encrypted.

This project will always break in production!

While using the HTTP out calls feature to communicate with external APIs from a caniter; it is recommanded to have a transformer function that will allow all the nodes in the ICP netowork/blockchain to reach the consensus on the same result from the request call. However it works locally because on local machine there is only one node.

Ref:

• https://internetcomputer.org/docs/current/references/https-outcalls-how-it-works#transformation-function

Thanks for the improvement vishnuvishwakarma

Hi Bonnix, The repository seems to be empty; it just contains the template of the canister in Motoko.

FYI, from Azle 0.23.* the type in dfx.json can be Azle as this version requires the dfx extension which makes it possible

Hi Blaz1988, I've opened a PR that improves the code.

My improvements to the code focus on using a Uint8Array instead of a Blob and leveraging the Buffer class to decode the binary data. Additionally, I've used optional chaining (?.) and the nullish coalescing operator (??) for more concise and readable code. I've also replaced the generic error message with more specific error messages for better clarity.

Here's a breakdown of the improvements:

1. Changed Parameter Type:
   • From: Blob
   • To: Uint8Array

Using Uint8Array is more explicit and might be considered more idiomatic when dealing with binary data.

2. Improved Decoding Process:

   • From: new TextDecoder('utf-8').decode(blob)
   • To: Buffer.from(blob.buffer).toString("utf-8")

   The updated code leverages the Buffer class for better compatibility and clarity.

3. Enhanced Error Handling:

   • The error messages are now more specific, providing information about the nature of the error.

4. Simplified Condition:

   • From: jsonData.data?.translations?.length > 0
   • To: jsonData.data?.translations?.length > 0

The use of optional chaining and nullish coalescing makes the condition more concise and easier to read.

5. Returned Result Type:
   • From: string
   • To: Result<string, string>

Using a Result type (assuming Ok and Err are part of a custom Result type) makes the return type more explicit and allows for better error handling.

6. Added TypeScript Type Assertion:
   • From: JSON.parse(text)
   • To: JSON.parse(text) as TranslationResponse

Using the as keyword for type assertion in TypeScript makes the intention clear and helps catch potential type-related issues.

These improvements collectively enhance the clarity, readability, and maintainability of the code, making it more understandable.

Thanks Jaxon for your improvement 🙂