Hello @nguoibian, love your project. I have gone through your code and made a few changes as stated below;

Fixes and Improvements

• Added NatSpec comments for better documentation. Read more here
• Edited the modifier to use the require statement rather than the if statement
• Changed the activeItem() mapping name to better fit the recommended naming convention. You can read more here
• Removed the notListed() modifier as it serves the same purpose as the isListed() modifier
• Removed the require statement on the listNft() function as the modifier isListed() is already used
• I changed the createNft() function name to mintNft() to indicate what the function does, which is to mint an Nft
• Noticed some code warnings on the frontend, went ahead to fix them replaced string concatenation using + with the backticks

That's all from me. I have made a pull request for you to go through and make the changes as you see fit. Great work once again

yeah, just noticed that too...will fix it immediately. Thank you

Hello @Kayzee, nice submission, I love the implementation. I went through the smart contract, and I would like to suggest a few changes and/or improvements.

Fixes and Improvement

• Changed the event name to better suit the naming convention. More info on this here
• Made changes to the struct property names, removing OG from struct property names as the struct already describes what the properties are for
• Added comments to some of the mapping variable and code blocks in the joinOG() function to better understand what they are meant to hold
• Noticed an owner of a fan card can purchase the fan card, added a check to prevent this from happening
• Add a check for the joinOG() function to prevent users from buying OG that do not exists, so I created a isValidId() modifier for this as it can be used in other functions
• I would suggest you use a better more descriptive variable name than OG to help other developers understand what the variable is meant to hold or store.

Below is the pull request for you to go through and make the changes as you see fit. Great submission again and have a nice weekend.

I have gone through your code and it's really amazing, the thought and the execution is really great. I noticed a few things with the project and they are;

1. I noticed that the create account modal wasn't centered on the page. So, edited the createAccount.tsx component to properly center the modal.

2. I noticed an error when a user tries to deposit an amount in a particular account after click on the view more button. This was because the type attribute for the input field was set to tel in the [id].tsx file. So, I changed it to number, and it can work as intended.

3. Rather than using 0001 as the account number, I would suggest you use a randomly generated value as the account number, this can then be sent to the smart contract and stored while creating an account. This will help separate the account index in the associationCreator mapping created from the account number. You can check out this package on how to do that and use it in your project.

4. I would suggest you create an orders.tsx in the executives folder located in pages/dashboard/[id] path, this way, executives will be able to see all withdrawal orders and their order number before knowing which order to approve or revert.

5. I would suggest you include an instruction on how to carry out certain actions on your project. This will help users get a better idea of what to do, how to do it and the expected result or outcome.

That's all the observation and changes I made. I couldn't make some of the changes as I would be altering the initial state of the project or adding a new feature. I have made a pull request below with the few changes I could make (staying in line with the feedback rules) for you to go through and make the changes suggested as you see fit.

Great project once again and all the best with your submission.

Hello @chigozie, I really love your project and the idea behind it. It's amazing. In addition to the changes proposed by @Farzeen, I made a few myself

H2 Improvements

1. In the getEventsById function of the smart contract, I edited the return statement to return an Event without specifying each property to return. This will help with the limitations associated with the number of properties a function can return
2. In the deleteEvent function in the main.js file, I added a check to prevent the wallet pop up from coming on when the button is clicked by a user other than the owner.
3. Although not a functionality problem, I edited the styles to prevent text overflowing outside its container.

That's basically everything, once again great submission and good luck.

I made a pull request with the proposed changes. You'll need to deploy the smart contract again and change the market contract address to effect these changes.

Thanks @Farzeen for your feedback. I really appreciate it

Hello Farzeen, I noticed your git repository you submitted is empty and only contains a README file.

Hello maryjobs, the GitHub repository you submitted is empty.

Hello @hexdee, loved you project, great submission. I have gone through your code base and made a few adjustments as stated below.

Fixes and Improvements

• Added NatSpec comments for better documentation of code. You can read more about it here
• I created an isValidId() modifier to replace the repeated use of the require statement to check if an ID is valid
• I changed the total variable name to totalCampaign to better describe what it is meant for.
• I removed the getTotal() function and made the totalCampaign variable public to access its value as the getTotal() function only returns its value.
• I added a require statement to the withdraw function to check if funds are available for withdraw and also reduced the raised property of the campaign by the amount withdrawn.
• On the frontend, I noticed a ReferenceError when a user tries to withdraw funds from a campaign due to the use of index in place of id in the main.js file. I made the necessary correction.
• I think you could add other functionalities like close a campaign, reopen campaign if it fits the purpose of the project.

I have made a pull request for you to go through the changes and make adjustments as you see fit. Really great submission and goodluck.

thanks Emmanuel...I was reading on modifier in solidity but couldn't figure out how to apply it to my code, wanted adding more features to it. I'll review your changes. Thanks again

Hello 4undRaiser, the GitHub repository you submitted is empty.

I would advise you build the project after making the changes so as to see the effected changes on the deployed live demo

Oh, I am sorry about that. The changes were made in RemixIDE, you can go through the pull request now. You should see the changes there now.

Hello @bezat, great project, loved the implementation. I went through your project and noticed a few things, though minor but I believe they will improve the user experience.

1. I added loading process to tell user a transaction is currently ongoing. This way multiple transactions will not be made or requested for
2. Noticed that when a user sends a message, the input fields doesn't clear after the message has been sent. Edited the code to clear the input field after a message has been sent or a comment has been made.
3. I would advise you add comments to your code for easy readability and although this is a frontend project, I would also advice you document your solidity code for the same reason.

That's all from me, overall, it was an amazing project. I've made a pull request with the suggested changes. Good luck.

Hello @Samthetutor, great work, I love the idea and the implementation. I went through you code (smart contract and the main.js file), didn't notice and bug. So in addition to @SinzuCrypto's feedback I made the following changes

Fixes and Improvement

• Added a loader to functions like donations, patients list etc to indicate fetching data
• Added a check to know if an address is whitelisted and if so, change and disable the whitelist button
• Removed the whitistedAddress array from the smart contract as there's already a mapping for this.

I've made a pull request so you can go through the changes. Great work and good luck with you submission.

Hello @Samm_47, the GitHub repository link you sent isn't working. It's redirecting to a 404 error page, saying page is not found

Great submission @Princeemmy, loved the implementation. I have gone through your code base (the smart contract and the App.js file as it holds the logic) and this is my contribution:

Feedback/Improvements

• Noticed you had functions in the ERC20 contract interface that were not used, so I removed those functions
• Removed and renamed some variables in the Voter struct as they were not really needed, I also added a votes mapping to keep track of all the votes of a particular voter
• Replaced how a new candidate is been added and how they are assessed, thus improving the solidity static analysis. Did the same for how a new voter is added in the giveVotingRight function. I also applied a check to determine if a voter has been given the right to vote or not.
• I removed some functions that only returns a variable already defined. I used these variables in place of the functions to access their values.
• I also noticed that the frontend has no notifications when performing certain actions like adding a candidate or giving voting rights so I added a simple notification for that to prevent users from initiating multiple clicks on a single action.
• I also added check similar to the checks in the smart contract on the frontend to prevent users from initiation a transaction before noticing an error with the initiated transaction.
• A user is allowed only a single vote and can't vote for multiple candidates, which is okay, but if you would like users to vote for multiple candidates, I added a function for that (although it's in comments so you can go over it if you feel there's a need to).

That's all from me, I have made a pull request with the suggested changes for you to go through and implement as you see fit. Once again great submission and good luck.

Hello @nguoibian, loved you project, and the functionalities implemented. It's really great. I have gone through your code base and made a few adjustments as stated below.

Fixes and Improvements

• Removed functions from the IERC20Token interface that were not used in the project
• Added NatSpec comments for better documentation of code. You can get more info on this here
• Changed the contract's file name to better suit the project
• Changed the mapping of name s_boughtItems to suit the naming convention for variables
• Edited the readProduct function to be able to return all the data about a product irrespective of the amount of data stored
• Removed the getProductLength function as it only returns the value of the productsLength variable. Made the productsLength varaible public so it can be used to get the product length.
• Added a .gitignore file to prevent uploading the node_modules folder to Github
• Added a require statement to prevent owners from buying their own products. This was done on the smart contract and on the frontend as well
• I made the necessary changes to the frontend code to accommodate the changes made to the smart contract.

I have made a pull request for you to go through the changes and make adjustments as you see fit. Really great submission and goodluck.

Hello @DextinyAB, great submission. I have gone through your code base and was able to find the reason for the error. Below are my observations and feedback on your submission.

Fixes and Improvement

• Modified the voters mapping to use uint mapped to a mapping of addresses and a Boolean indicating their voting choice. This was the reason behind the error you got earlier after creating the second proposal and trying to vote on that proposal.
• Added NatSpec comment, you can read more about it here
• Edited the readProposal() function to display all the properties of the Proposal struct for increased efficiency
• Removed the getProposalLength() function as it only returns the proposalLength. Made this variable public so it value can be read.

That's all from me. I have made a pull request for you to go throw and make the necessary changes as you see fit. Great submission, goodluck.

Thats great...loved the project, these are my observations and feedback on your project

Fixes and Improvements

• Noticed that any user can delete the content, so I added a check on the smart contract and the frontend to prevent this.
• I also added a check on the frontend to prevent owner from initiating the booking function. This was already added in the smart contract.
• Deleted the getTotalShows() function as it only returns the value of totalShows() variable. So, I used the totalShows variable instead of the getTotalShows() function.

Great submission by the way, I have made a pull request for you to go through the changes and implement as you see fit. Make sure you test your application after implementation to make sure it works as planned. Good luck

Hi @Lypso, I really love your project. I have gone through the contract and made a few addition to it.I added an email and a password verification code to the JavaScript file and a little notification on the HTML file as well. I've made a pull request, so you can review the additions I've made. Once again, great submission.

Hello @Peacevian, great submission, loved the idea, implementation and the simplicity of the project. I went through you code (the smart contract and the code in the main.js file) and have a few observations.

Feedback/Improvements

• Noticed some functions in the smart contract only returns a state variable, so I removed those functions and made the state variable public so it can be accessed outside the contract
• Deleted the array emailAddress as there's a mapping (emailExist) that can perform the same purpose as the array.
• I noticed you requests for user's email to get started with the DApp, this kind of defeats the major purpose of a decentralized application which is anonymity, where user's details are secured by cryptography. So, I used the user's wallet address instead and made the relevant changes to the frontend code in the main.js file.
• I also made changes to the smart contract to fit the observation above.

I've made a pull request with the proposed changes for you to go through and implement if it meets the dApp specifications. Great work again and all the best on your submission.

Hello @Temi_empirical, the GitHub link you are to submit is a link to your project repository and not the live link of the project you built.

The correction has been made. Thank you

Hello Kayzee, I noticed that the link you submitted is not the projects GitHub repository link but a link to deployed project on vercel. Please send the repository link so feedbacks can be made, if any, on your project.

Hi @patrickcmd, love your project and the implementation. I have gone through you smart contract code and made a few changes

Fixes and Improvements

• Changed the variable naming convention to mixedCase. You can read more here for variable naming conventions Naming Convention
• Removed the getMoviesLength function as it can be accessed from the moviesLength variable by making it public
• Removed the getMovieUserReviews, getMovieImbdScore, getMovieContentRating, getMovieImbdLink functions as the values they return can be accessed from the readMovies function
• Edited the readMovies function, this way you can access any and all the properties of a movie.
• Used a NatSpec format for better documentation of the smart contract code. You can read more about it here
• Added a require statement to prevent an owner of a movie to view his/her own movie as this will falsely increase the reviews of a movie.
• Made the necessary changes to the main.js file to align with the changes made to the smart contract

That's all from me. I have made a pull request for you to go through and see the changes made. To effect the changes, you'll need to build the project again. Great submission and good luck.